ZOOKEEPER-3433 zkpython build broken after maven migration - #991
Conversation
Fixed the build and test infrastructure for zkpython. Verified the build and tests all passing under both ubuntu and macos. Change-Id: I3c80774a2712f280d1f14739d1eb78baa066fdc6
|
|
||
| # Find the build directory containing zookeeper.so | ||
| SO_PATH=`find ../../../build/ -name "zookeeper.so" | head -1` | ||
| SO_PATH=`find ../../build/ -name "zookeeper.so" | head -1` |
There was a problem hiding this comment.
Isn't any 'target' directory name?
Did you build with raw 'make' the c client?
There are multiple ways to build the C client
There was a problem hiding this comment.
I used ant to build the c client as maven doesn't seem to be working (the c client is not being built even with "full-build" profile). That's the way it was always done on the past - just continuing until we have a maven based approach. So with this we get back to status quo - after the directory structure changes for maven I mean.
I did a "ant clean compile compile-native" at the toplevel, then "ant compile" and "ant test" within the zookeeper-contrib-zkpython directory.
|
@eolivelli can you +1 this (or @anmolnar ) or give me addl feedback? I have some addl patches for python3 that i'd like to land. thanks. |
|
How can I test this patch locally? |
I did a "ant clean compile compile-native" at the toplevel, then "ant compile" and "ant test" within the zookeeper-contrib-zkpython directory. You need to have python2 installed and the dev libraries available. That runs all the tests for zkpython (with this patch applied) |
nkalmar
left a comment
nkalmar
left a comment
There was a problem hiding this comment.
Tested before (failed at ant compile in zkpython) and after patch. Works fine on Ubuntu with python2.
+1
Fixed the build and test infrastructure for zkpython. Verified the build and tests all passing under both ubuntu and macos. Change-Id: I3c80774a2712f280d1f14739d1eb78baa066fdc6 Author: Patrick Hunt <phunt@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes #991 from phunt/zk3433 (cherry picked from commit 2711d69) Signed-off-by: Norbert Kalmar <nkalmar@apache.org>
|
Committed to master and 3.5 (tested, this patch also solves it on 3.5, which has the same problem) |
Fixed the build and test infrastructure for zkpython. Verified the build and tests all passing under both ubuntu and macos. Change-Id: I3c80774a2712f280d1f14739d1eb78baa066fdc6 Author: Patrick Hunt <phunt@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes apache#991 from phunt/zk3433
Fixed the build and test infrastructure for zkpython. Verified the build and tests all passing under both ubuntu and macos. Change-Id: I3c80774a2712f280d1f14739d1eb78baa066fdc6 Author: Patrick Hunt <phunt@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes apache#991 from phunt/zk3433
Fixed the build and test infrastructure for zkpython. Verified the build and tests all passing under both ubuntu and macos. Change-Id: I3c80774a2712f280d1f14739d1eb78baa066fdc6 Author: Patrick Hunt <phunt@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes apache#991 from phunt/zk3433
3 participants
Fixed the build and test infrastructure for zkpython.
Verified the build and tests all passing under both ubuntu and macos.
Change-Id: I3c80774a2712f280d1f14739d1eb78baa066fdc6